-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support l2 plus fendermint tests #1177
Open
karlem
wants to merge
12
commits into
support-l2-plus
Choose a base branch
from
support-l2-plus-fendermint-tests
base: support-l2-plus
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlem
commented
Oct 20, 2024
// Run the command and handle errors | ||
let output = cmd.output().context("failed to run forge create")?; | ||
|
||
println!("OUT: {}", String::from_utf8_lossy(&output.stdout)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karlem print stderr in case of failure
.first() | ||
.cloned() | ||
.unwrap_or_else(|| { | ||
panic!("No node with ethapi_http_endpoint found in the contract deployment config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not panic. Return an error
karlem
changed the title
Support l2 plus fendermint tests
feat: support l2 plus fendermint tests
Oct 28, 2024
karlem
force-pushed
the
support-l2-plus
branch
from
October 28, 2024 14:35
0d896a7
to
ff75e79
Compare
karlem
force-pushed
the
support-l2-plus-fendermint-tests
branch
from
October 28, 2024 15:04
751c615
to
a8aa488
Compare
karlem
force-pushed
the
support-l2-plus-fendermint-tests
branch
from
October 28, 2024 15:06
a8aa488
to
2f44952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1080
End-to-End Testing with Fendermint
Changes and Improvements in Materializer for Testability
L2+ Subnet Deployment Improvements: Deploying L2+ subnets was previously hindered by insufficient wait times for the deployer's balance to be funded during the top-down finalization process. To address this, a
wait_for_balance
function has been added, which ensures the deployer has a positive balance before proceeding.Custom Contract Deployment for L2+ Testing: Testing L2+ subnets requires deploying custom contracts, such as the IPC handler actor at the destination. Additionally, only smart contracts (not EOAs) are permitted to trigger cross-network messages. To support this, Materializer now includes a
solidity_deployments
field in the subnet manifest to enable the deployment of Solidity contracts.Helper Contracts for Testing: Simple helper contracts have been added to the Materializer for testing purposes. These include contracts to trigger cross-net messages and manage IPC handlers at the destination.