fix(version bump): manual version bump and clean up (#762)

consensys-vertical-apps · Jul 2, 2024 · 5135d9c · 5135d9c
1 parent 35297cc
commit 5135d9c
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 10 deletions.
diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -2,7 +2,7 @@
   "packages/institutionalFeatures": "1.3.5",
   "packages/simpleCache": "1.1.0",
   "packages/types": "1.1.0",
-  "packages/custodyController": "0.2.30",
+  "packages/custodyController": "0.2.31",
   "packages/custodyKeyring": "2.0.3",
   "packages/sdk": "0.1.30",
   "packages/transactionUpdate": "0.2.5",

diff --git a/packages/custodyController/package.json b/packages/custodyController/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@metamask-institutional/custody-controller",
-  "version": "0.2.30",
+  "version": "0.2.31",
   "description": "Custody controller is a background controller responsible for maintaining a cache of custody data in local storage",
   "author": "Albert Olive <albertolivecorbella@gmail.com>",
   "homepage": "https://github.com/consensys-vertical-apps/metamask-institutional#readme",

diff --git a/packages/custodyKeyring/src/CustodyKeyring.ts b/packages/custodyKeyring/src/CustodyKeyring.ts
@@ -455,8 +455,6 @@ export abstract class CustodyKeyring extends EventEmitter {
     return this.accountsDetails.find(account => account.address.toLowerCase() === address.toLowerCase());
   }
 
-  // TODO: This methods should be rename 'get signed message'
-
   async getSignature(address: string, signatureId: string): Promise<ISignatureDetails> {
     if (signatureId === undefined) {
       return null;

diff --git a/packages/sdk/src/classes/MMISDK.ts b/packages/sdk/src/classes/MMISDK.ts
@@ -186,7 +186,3 @@ export class MMISDK extends EventEmitter {
 }
 
 export { ICustodianDetails } from "../interfaces/ICustodianDetails";
-
-// @TODO We don't need it right now, come back later after CustodyKeyring is in its own package
-// and check if we still want to export it here for some reason
-// export { CustodyKeyring } from "./CustodyKeyring";
diff --git a/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts b/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts
@@ -71,8 +71,6 @@ export class JsonRpcCustodianApi extends EventEmitter implements ICustodianApi {
   async getEthereumAccountsByAddress(address: string): Promise<IEthereumAccount<IEthereumAccountCustodianDetails>[]> {
     const accounts = await this.getEthereumAccounts();
 
-    // TODO: This is a bit inefficient, but eventually we may add optional filtering to the JSON-RPC API
-
     return accounts.filter(account => account.address.toLowerCase().includes(address.toLowerCase()));
   }