Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdDSA gadget #257

Merged
merged 15 commits into from
Feb 15, 2022
Merged

EdDSA gadget #257

merged 15 commits into from
Feb 15, 2022

Conversation

yelhousni
Copy link
Contributor

@yelhousni yelhousni commented Feb 14, 2022

Reduce the number of constraints of a single EdDSA verification (e.g. Groth16/BN254 -2049 constraints).

@yelhousni yelhousni added the perf label Feb 14, 2022
@yelhousni yelhousni marked this pull request as draft February 14, 2022 10:53
@yelhousni
Copy link
Contributor Author

Modulo Lookup2 for fixed inputs in PLONK #254

@ThomasPiellard
Copy link
Collaborator

So the error was not the lookup table but a wrong op in the sparse_r1cs constraint system:
r.ModInverse(&r, q).Mul(&l, &r).Mod(&l, q) instead of
r.ModInverse(&r, q).Mul(&l, &r).Mod(&r, q)

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 14, 2022

@yelhousni still a draft?

@yelhousni yelhousni marked this pull request as ready for review February 14, 2022 21:48
@yelhousni
Copy link
Contributor Author

@yelhousni still a draft?

PR is ready after Thomas' fix.

@gbotrel gbotrel merged commit 31dbe2f into develop Feb 15, 2022
@gbotrel gbotrel deleted the perf/EdDSA branch February 15, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants