fix(emulated): enforce widths of packed limbs #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests failed due to stats difference. It seems that this fix increases the number of internal variables and constraints for field emulation stats circuit. But after reviewing it seems that it is correct as previously the limbs output by hints were not width-constrained. Now they are implicitly constrained by the |
gbotrel
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a new emulated element using
PackLimbs, we manually checked that the whole width of the constructed element corresponds to the modulus. However,PackLimbswas only used in contexts where we constructed an element from a single limb. Then it makes more sense to check only that it is constructed from a limb which is in range.