clarify some allow docs per review

consideRatio · Apr 2, 2024 · 3ce2643 · 3ce2643
1 parent 3e61e46
commit 3ce2643
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docs/source/tutorial/getting-started/authenticators-users-basics.md b/docs/source/tutorial/getting-started/authenticators-users-basics.md
@@ -130,7 +130,8 @@ By default, only the deprecated `admin` role has global `access` permissions.
 ## Add or remove users from the Hub
 
 :::{versionadded} 5.0
-`c.Authenticator.allow_existing_users` is added in 5.0 and enabled by default.
+`c.Authenticator.allow_existing_users` is added in 5.0 and True by default _if_ any `allowed_users` are specified.
+
 Prior to 5.0, this behavior was not optional.
 :::
 

diff --git a/jupyterhub/auth.py b/jupyterhub/auth.py
@@ -166,7 +166,8 @@ def check_allow_config(self):
  self.log.warning(
  "No allow config found, it's possible that nobody can login to your Hub!\n"
  "You can set `c.Authenticator.allow_all = True` to allow any user who can login to access the Hub,\n"
- "or e.g. `allowed_users` to a set of users who should have access."
+ "or e.g. `allowed_users` to a set of users who should have access.\n"
+ "You may suppress this warning by setting c.Authenticator.any_allow_config = True."
  )
 
  whitelist = Set(