Add 256 colors support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
approved these changes
Aug 10, 2020
dtolnay
pushed a commit
to dtolnay-contrib/console
that referenced
this pull request
Feb 4, 2022
This branch adds color-coding for durations based on their unit, as described in console-rs#71. The colors are a simple gradient, from picoseconds to whole seconds. Currently, the unit is detected by formatting the value using the `fmt::Debug` impl for `Duration`, and looking at the last two characters to determine the unit. Admittedly, this is kind of janky, but it seemed like re-implementing all of the `Duration` formatting logic would be worse. Right now, this assumes the terminal supports the ANSI 256-color palette. I'm working on an additional change to detect what color palettes the terminal supports and select colors based on that, but I figured I'd do that in a separate PR. Here's a little example screenshot:  Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Color::Color256(u8)for 256 colors support like below: