You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By default I have Barrier #1 and #2 uncommented. If you comment out barrier #2 and uncomment #3, you see correct behavior (since executing proceeds after the Arc is dropped). You can also comment out all the Barriers and you should get correct behavior (unless of course, the race happens organically 😉).
The text was updated successfully, but these errors were encountered:
djc
changed the title
Ticker threads should be joined, otherwise they can race and lead to spinners that aren't properly finished
Ticker thread might block final draw on progress bar
Mar 23, 2022
I don't think a custom tick implementation is possible without the user
running into essentially issue console-rs#416. Coordination would be necessary
between the custom ticker and the progress bar to ensure that the custom
tick thread is joined.
I don't think a custom tick implementation is possible without the user
running into essentially issue console-rs#416. Coordination would be necessary
between the custom ticker and the progress bar to ensure that the custom
tick thread is joined.
The order of events would be:
Ticker
and it starts chugging along.main
returns or panics, theProgressBar
(s) go out of scope and should be dropped.Ticker
is executing this line:indicatif/src/state.rs
Line 310 in 515a2a9
main
returned, the thread is killed whileTicker
is executing that line.Arc
is still held, sofinish_using_style
is never called and the spinner is not cleared.From #407 (comment):
The text was updated successfully, but these errors were encountered: