Bespoke parser #130
Merged
Bespoke parser #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
force-pushed
the
bespoke-parser
branch
from
42406da to
1bf9f0a
Compare
This was referenced Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disposition
This pull request:
Summary
Remove phpdocumentor/reflection-docblock.
Description
Many different projects use phpdocumentor/reflection-docblock with differing version constraints. This has sometimes made it difficult to run composer update without removing the lock file, or other workarounds that should not be necessary. There have also been reports of version 4 not always working correctly with this project.
This PR removes phpdocumentor/reflection-docblock in favor of a bespoke parser. It might even be a touch faster.