Update to PHP 7.1 Features #1041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start with Runner.php
- `loadRoboFile(?OutputInterface)` fixed to accept null - `getRoboFileCommands(?OutputInterface)` also fixed to accept null
- Fix incomlete or wrong docblocks - Add some missing function return types
- Add types to function signatures as well as return types in Robo.php - Fix incomplete or wrong docblocks
- Add types to function signatures as well as return types in Robo.php - Fix incomplete or wrong docblocks
|
c.f. #1081 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Runner.php and Robo.php updated to use scalar type hinting as well as return type designations which are PHP 7.1 features.
Description
Nearly every function has been fixed and the docblocks updated.
Note: In
Runner::execute()the line:$commandFiles = $this->getRoboFileCommands($output);can return a plethora of return types.Recommend adding some
asserts()