Made it work on Linux. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the conflicts. |
|
OK, I fixed all the conflicts, can you test whether it works for me? Thanks |
|
will do! |
|
Sorry, I either forgot to do this or it was overwritten at some point. If it wasn't compiling it should now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue is now I have no clue about Mac compatibility. It links against libc so there's technically one dependency now.
It just gets the
TIOCGWINSZfrom C because I have no idea how to do it using the standard library (maybe there's a way)I also had to change the
winsizestruct to use the libc version because it has not yet been written into std.c which would get used understd.os.systemif you linked libc.If you agree with the changes could you please check they work?
Thanks