This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 125
trusty used to build and added link_uri in click activity response Development #163
Open
yousafsaqib
wants to merge
31
commits into
constantcontact:master
Choose a base branch
from
yousafsaqib:development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get a LOT of support volume about welcome emails not sending due to using this and not realizing how to set that. Defaulting welcome email to on here.
Update to Guzzle 6
Properly retrieve message body from Guzzle prior to calling json_deco…
* Improved performance and decrease the memory usage by sharing a single Client across all services. * Allow a GuzzleHttp\Client to be injected during instantiation so that a mock can be used for testing.
Still some things to do: - [ ] Build out EventSpotService.php to support [full range of methods](https://github.com/constantcontact/ruby-sdk/blob/master/lib/con stantcontact/services/event_spot_service.rb) - [ ] Some missing classes still exist
Also, fix the URL for promocode endpoints
…spot # Conflicts: # src/Ctct/Services/BaseService.php # src/Ctct/Util/Config.php
Update for PSR7
…i-for-guzzle Make GuzzleHttp\Client Injectable and Shared
Fix remaining methods to use `sendRequestWithBody()` instead of `send()`.
`OAuth2Exception::setErrors()` expects an array. `json_decode()` was sending an object.
Add EventSpot Components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.