Fix typos #193
Fix typos #193
Conversation
| #ifndef BOOST_FILESYSTEM_NO_DEPERECATED | ||
| #define BOOST_FILESYSTEM_NO_DEPERECATED | ||
| #ifndef BOOST_FILESYSTEM_NO_DEPRECATED | ||
| #define BOOST_FILESYSTEM_NO_DEPRECATED |
There was a problem hiding this comment.
Is BOOST_FILESYSTEM_NO_DEPRECATED still required? I'm asking because BOOST_FILESYSTEM_NO_DEPRECATED was clearly not defined until now, and yet this has been working.
BTW, it is clearly a z5 typo, not a Boost typo, because as far as I can see, BOOST_FILESYSTEM_NO_DEPERECATED has never been used in Boost:
https://github.com/search?q=org%3Aboostorg+BOOST_FILESYSTEM_NO_DEPERECATED
unlike BOOST_FILESYSTEM_NO_DEPRECATED:
https://github.com/search?q=org%3Aboostorg+BOOST_FILESYSTEM_NO_DEPRECATED&type=commits
There was a problem hiding this comment.
This is probably not required anymore since all major builds are using c++17 and std::filesystem now,
Anyway, good to fix this in case some legacy builds with boost filesystem are still around.
There was a problem hiding this comment.
Actually BOOST_FILESYSTEM_NO_DEPRECATED will disable deprecated parts of the Boost API. I understand this is an internal z5 issue that will not result in z5 API changes. Since all tests still pass, I guess it's OK.
| @@ -60,7 +60,7 @@ macro(addPythonModule) | |||
|
|
|||
| set(options "") | |||
| set(oneValueArgs NESTED_NAME) | |||
| set(multiValueArgs SOURCES LIBRRARIES) | |||
| set(multiValueArgs SOURCES LIBRARIES) | |||
There was a problem hiding this comment.
I hope this wasn't on purpose...
|
Thanks! |
Those were not found by codespell 😃