Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 to CI builds #210

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add Python 3.10 to CI builds #210

merged 2 commits into from
Sep 14, 2022

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@constantinpape
Copy link
Owner

Indeed, looks like some dependency conflict due to the version pinning.
We can try to loosen the pins and see if this fixes the conflicts and if builds are still passing.

@DimitriPapadopoulos
Copy link
Contributor Author

I could be a problem of dependencies:

Ensuring environment...

[...]
  Making patched copy of 'environment-file: .github/workflows/environment.yaml'
  Using: /home/runner/work/z5/z5/.github/workflows/setup-miniconda-patched-environment.yaml
  name: z5-build-env
  channels:
    - conda-forge
  dependencies:
    - cmake
    - compilers
    - bzip2
    - lz4-c
    - xz
    - zlib
    - boost-cpp>=1.63
    - 'xtensor>=0.21,<0.22'
    - 'xtensor-python>=0.24,<0.25'
    - 'xsimd >=7,<8'
    - blosc
    - imageio
    - nlohmann_json
    - zarr
    - h5py
    - python=3.10

But then I cannot make any sense of the description of the conflicts. Conflicts are everywhere and it is not easy to pinpoint the root cause (I would bet on 'xtensor>=0.21,<0.22' / 'xtensor-python>=0.24,<0.25' but that's only a gut feeling).

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Sep 13, 2022

Fixed CI by removing version pinning here:

- xtensor 0.19.3
- xtensor-python 0.22.1

and here:
- xtensor>=0.21,<0.22
- xtensor-python>=0.24,<0.25
- xsimd >=7,<8

I don't know why version pinning is required and how you find the proper version to use.

@constantinpape
Copy link
Owner

Thanks for looking into this!

I don't know why version pinning is required and how you find the proper version to use.

The version pins are required because the xtensor projects have a fairly unstable API, so just installing the latest version is a bit dangerous.
For the correct version pins you can take the ones from conda-forge: https://github.com/conda-forge/z5py-feedstock/blob/main/recipe/meta.yaml#L27-L29. They should work for python 3.10.

(Sorry that I realized this only now; just recalled that I had the same issues for the python 3.10 build on conda-forge half a year ago or so.)

@DimitriPapadopoulos
Copy link
Contributor Author

I have updated .github/workflows/environment.yaml accordingly.

I don't know what to do with conda-recipe/meta.yaml:

- xtensor 0.19.3
- xtensor-python 0.22.1

Copy link
Owner

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(And the changes in the conda-recipe are fine; this one is deprecated and just left here for reference.)

@constantinpape constantinpape merged commit 2c38476 into constantinpape:master Sep 14, 2022
@DimitriPapadopoulos DimitriPapadopoulos deleted the python3.10 branch September 14, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants