Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unchecked TOTP constructor and URL parsing methods #48

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

timvisee
Copy link
Contributor

@timvisee timvisee commented Jan 3, 2023

Fixes #46

This adds TOTP::new_unchecked as discussed.

This also adds TOTP::from_url_unchecked which uses TOTP::new_unchecked internally to allow unchecked URL parsing.

I will rebase #47 after this is merged.

@timvisee
Copy link
Contributor Author

timvisee commented Jan 3, 2023

I just noticed I didn't add tests for this. I'll do that later.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Base: 96.69% // Head: 95.81% // Decreases project coverage by -0.88% ⚠️

Coverage data is based on head (d293068) compared to base (d460bd2).
Patch coverage: 75.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   96.69%   95.81%   -0.89%     
==========================================
  Files           4        4              
  Lines        1242     1290      +48     
==========================================
+ Hits         1201     1236      +35     
- Misses         41       54      +13     
Impacted Files Coverage Δ
src/lib.rs 94.65% <75.47%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@constantoine constantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@constantoine constantoine merged commit 76e9bb7 into constantoine:master Jan 4, 2023
@timvisee timvisee deleted the feature-unchecked branch January 5, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable 128-bit requirement
3 participants