Add abilities to valuator model for comment and edit dossiers #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 11, 2019
abelardogilm
changed the title
|
Failing SPEC: rspec ./spec/features/comments/budget_investments_spec.rb:404 As this spec is not in that PR, I think we need to investigate it to tag it as flaky test, |
|
@abelardogilm Fixed by #3596 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#3428
Objectives
Adding that new abilities, admin users can manage valuators to allow them to comment or edit dossier information, enabling and updating the resource. With that, we can have a new type of valuator that can only make evaluation comments, or can only edit dossiers, or can do both. And it will allow to create new abilities easily in future feautures
Visual Changes
Admin
valuators
valuator edit
valuator show (with checks enabled)
valuator show (without checks enabled)
Valuator
Can comment && !can edit dossier
Can edit dossier && !can comment
Can comment && can edit dossier
!Can comment && !can edit dossier
Notes
By default, but properties will be set as enabled to allow current users have current functionality
Admin users will be allowed to comment and edit dossiers.