Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valid votes labels #3570

Merged
merged 3 commits into from
May 30, 2019
Merged

Fix valid votes labels #3570

merged 3 commits into from
May 30, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented May 30, 2019

References

Objectives

  • Fix results shown in the admin section
  • Clarify "total ballots" only include valid ballots

javierm added 3 commits May 30, 2019 17:22
@javierm
Fix valid ballots label
6881ee1 
It was incorrectly labeled as "total ballots", which actually meant
"total valid ballots", but users were unsure as to whether include
blank and invalid ballots in that amount.
@javierm
Display the same results for stats and recounts
123196e 
In the recounts we were incorrectly assuming the total amount included
the blank and invalid ballots.
@javierm
Include blank and null ballots in booth totals
31515dd 
Just the same way it's done for all polls.
@javierm javierm self-assigned this May 30, 2019
@javierm javierm merged commit 137daba into master May 30, 2019
@javierm javierm deleted the valid_votes branch May 30, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microweb10 microweb10 microweb10 approved these changes

@decabeza decabeza decabeza approved these changes

Assignees

@javierm javierm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierm @decabeza @microweb10