Order legislation process tags alphabetically #3969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
The method
tag_list_on
doesn't add anORDER_BY
clause to the SQL query it generates, and so results may come in any order.However, in the tests we were assuming the tags were ordered by ID in descending order. Since that isn't always the case, the tests were failing sometimes. The user experience was also not that great since tags could be ordered differently after reloading the page.
Objectives
Make sure legislation process tags are always ordered the same way.
Notes
One test failed with this message:
We could also use the same order admins used when adding the tags:
However, I'm not sure it improves the user experience, and it makes the code more complicated.
benefit to administratos.