Fix Airbrake crash with no project key #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking tho project_id but not the project_key. However, in our example secrets file we actually include a project_id but not a project_key, and so new CONSUL installations would crash in production environments. Although technically the application doesn't crash if no host is defined, we're also ignoring the current environment if no host is defined, since errbit/airbrake is unlikely to work in this scenario.
javierm
force-pushed
the
fix_airbrake
branch
from
d8f9aa1 to
a1bb9bd
Compare
taitus
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We were checking the project_id but not the project_key. However, in our example secrets file we actually include a project_id but not a project_key, and so new CONSUL installations would crash in production environments.
Objectives
Ignore Errbit settings when no project key is provided.