Improve filling in dates in specs #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
approved these changes
Mar 30, 2021
javierm
force-pushed
the
notification_relative_urls
branch
from
eb59431 to
d7563be
Compare
We were filling in dates with times, which is not what users would do.
The line `fill_in "advanced_search_date_max", with: "wrong date"` doesn't work because the jQuery UI datepicker prevents users from entering that value.
Some tests were failing depending on the window resolution due to the datepicker making it impossible to click the "Filter" button. They were also failing if using `clear: :backspace` to fill in those fields. So we're focusing on a different field in order to hide the datepicker and click the "Filter" button.
Tests are easier to read now. Besides, since we changed the inputs in the admin section so they don't use jQuery but an HTML date field, formatting with %d/%m/%Y might not work depending on the browser's locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives