Remove ES6-specific syntax in amsify suggestags #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
force-pushed
the
remove_es6_syntax
branch
from
60d3eeb to
abc659a
Compare
javierm
force-pushed
the
remove_es6_syntax
branch
from
abc659a to
7d97e4c
Compare
javierm
force-pushed
the
remove_es6_syntax
branch
from
7d97e4c to
4153e52
Compare
It was causing JavaScript to stop working completely on old browsers which don't support this syntax.
taitus
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
We don't officially guarantee all JavaScript will work on old browsers, but we do our best to make the page usable to a reasonable degree on them because the main goal of CONSUL is to help organizing participatory processes where all citizens can participate.
We're getting warnings from ESLint. However, we're ignoring them since this is a vendor file and follows its own conventions.