Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade airbrake from 11.0.3 to 7.4.0 #4646

Merged

Conversation

javierm
Copy link
Member

@javierm javierm commented Aug 12, 2021

References

Background

Two of the custom information texts tests fail sometimes because the page takes too long to load. After upgrading airbrake, maybe because of the way requests are intercepted, or maybe because of the rbtree3 dependency, it looks like requests are a bit slower and so these tests were failing 100% of the time.

While we investigate the issue, we're downgrading to the latest version of Airbrake where the tests still pass.

Objectives

  • (Maybe) Remove one source of performance degradation
  • Make sure all tests pass

@javierm javierm added the dependencies Pull requests that updates a dependency label Aug 12, 2021
@javierm javierm self-assigned this Aug 12, 2021
@javierm javierm force-pushed the revert-4608-dependabot/bundler/master/airbrake-11.0.3 branch from 30245f6 to 74f7720 Compare August 12, 2021 13:52
Two of the custom information texts tests fail sometimes because the
page takes too long to load. After upgrading airbrake 9ac8528, maybe
because of the way requests are intercepted, or maybe because of the
rbtree3 dependency, it looks like requests are a bit slower and so these
tests were failing 100% of the time.

While we investigate the issue, we're downgrading to the latest version
of Airbrake where the tests still pass.
@javierm javierm merged commit 0c02b78 into master Aug 12, 2021
@javierm javierm deleted the revert-4608-dependabot/bundler/master/airbrake-11.0.3 branch August 12, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant