Disable scroll wheel for zooming in favor of map zoom buttons #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing annoying behaviour for desktop users when scrolling the page to the bottom and there is more content below the map. The behaviour of touchable devices does not seem to be affected by this change and keeps behaving the same.
javierm
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Replaces:
Objectives
Fix the mousewheel trap when scrolling the page to the bottom when there is more content below the map.
Manual testing
Desktop browsers
Verified successfully in:
This update has no impact in touchable devices as they do not have mouse wheel. It seems the map behaves nicely with all the browsers mentioned above.
Visual Changes
None