Dub mapping Improvements #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dub and subs - Anilist now finds animeinfo more accurately for dub - mapping episodes is now possible in the future.
riimuru
reviewed
Nov 9, 2022
riimuru
requested changes
Nov 9, 2022
riimuru
requested changes
Nov 9, 2022
riimuru
requested changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This pr fixes some issues where gogoanime was not returning the correct dub episodes. This also fixes issues where some providers might have bad search functionality when retrieving anime information. This will allow more accurate results when fetching for episodes.
Did you add tests for your changes?
Nope.
If relevant, did you update the documentation?
N/A
Summary
I want to be able to watch the correct episode and if I change providers, to make sure it returns the correct anime information.
Other information
I bumped the version to 1.2.7 and updated changelog.