Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mangadex null page numbers #108

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Fix mangadex null page numbers #108

merged 1 commit into from
Nov 13, 2022

Conversation

riimuru
Copy link
Contributor

@riimuru riimuru commented Nov 13, 2022

What kind of change does this PR introduce?

  • Fixes managdex null page numbers in issue #107

@riimuru riimuru added the enhancement New feature label Nov 13, 2022
@riimuru riimuru linked an issue Nov 13, 2022 that may be closed by this pull request
Page labels for mangadex images are null #107
Closed
@riimuru riimuru removed the request for review from prince-ao November 13, 2022 22:57
@aidanjuma aidanjuma self-assigned this Nov 13, 2022
@riimuru riimuru marked this pull request as draft November 13, 2022 22:58
@aidanjuma aidanjuma self-requested a review November 13, 2022 22:58
@riimuru riimuru self-assigned this Nov 13, 2022
aidanjuma
aidanjuma approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@aidanjuma aidanjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine and LGTM 👍

@aidanjuma aidanjuma marked this pull request as ready for review November 13, 2022 23:03
@aidanjuma aidanjuma merged commit 9900189 into master Nov 13, 2022
aidanjuma added a commit that referenced this pull request Nov 13, 2022
@aidanjuma
Revert "fixed mangadex page numbers (#108)"
a0eb9f8 
This reverts commit 9900189.
@aidanjuma aidanjuma mentioned this pull request Nov 13, 2022
Merged
riimuru added a commit that referenced this pull request Nov 14, 2022
@aidanjuma @riimuru
Improvements (#109)
431e4f3 
* Revert "fixed mangadex page numbers (#108)"

This reverts commit 9900189.

* fix mangadex null page numbers

* fix anilist fallback

* deprecate subOrDub property

* quick fix for anilist

Co-authored-by: riimuru <mythhb@yahoo.com>
@riimuru riimuru changed the title Improvments Fix mangadex null page numbers Nov 18, 2022
@aidanjuma aidanjuma deleted the Improvments branch December 10, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanjuma aidanjuma aidanjuma approved these changes

Assignees

@aidanjuma aidanjuma

@riimuru riimuru

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page labels for mangadex images are null
2 participants
@riimuru @aidanjuma