Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cover image from the search results #563

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

gilbertlucas46
Copy link
Contributor

@gilbertlucas46 gilbertlucas46 commented Jul 18, 2024

What kind of change does this PR introduce?

Added image from the search results endpoint.

Did you add tests for your changes?
Yes I did.

Sample response
http://0.0.0.0:4001/manga/mangadex/100 Ways Not to Fail in Another World
{ "currentPage": 1, "results": [ { "id": "7c7bc515-5427-4b56-915a-ebf1c04ee3d8", "title": "Isekai de Shippai Shinai 100 no Houhou", "altTitles": [ { "en": "100 Ways to Not Fail in an Alternate World" }, { "ja-ro": "Isekai de Shippaishinai 100 no Houhou" }, { "zh": "在异世界不失败的一百种方法" }, { "ja": "異世界で失敗しない100の方法" } ], "description": "To Chie Souma, a female college student, every day feels depressing when she has no luck with job hunting. She’d much rather end up in an alternate universe, just like in her beloved tripping into another world novels… Just as she was dreaming of escaping this reality, one day she actually trips into another world! It might be too dangerous in a female body to survive in this world. Chie decides to use the knowledge that she’s gained from reading, lie about her gender, and become “Souma the scholar,” but—?! A manga adaptation of a strategy manual style fantasy.", "status": "completed", "releaseDate": 2017, "contentRating": "safe", "lastVolume": "5", "lastChapter": "30", "image": "https://mangadex.org/covers/7c7bc515-5427-4b56-915a-ebf1c04ee3d8/0f3148a1-b76f-48f9-be7c-484b57b75ccd.jpg" } ] }

If relevant, did you update the documentation?

I did not update the Docs

Summary

I needed images from the search results aside from the title and description etc.

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants