Change “ID” to “Id” in Method names

[saad-ali]

Recommendation from a gRPC author after review of CSI API: follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case style guide

Specifically, GetNodeID(...) should be GetNodeId(...)

[saad-ali]

If we do this, @jieyu suggested renaming GetNodeId() to NodeGetId() for consistency with other method names in the Node service.

[jieyu]

xref #137

@akutz suggested that

[saad-ali]

Closed with #182

[pure-yesmat]

Hello,

This causes golint to fail for NodeGetId because it expects NodeGetID. Is the recommendation to ignore this error?

Should we use something like this for the go generated file:

you can use github.com/gogo/protobuf

message C {
	optional int64 size = 1 [(gogoproto.customname) = "MySize"];
}
type C struct {
	MySize		*int64
}

This is a snippet from: golang/protobuf#156

Thanks

[jdef]

Where is golint failing, exactly? When linting your client code, or the generated proto bindings?

…

On Wed, Mar 7, 2018 at 3:47 PM, pure-yesmat ***@***.***> wrote: Hello, This causes golint to fail for NodeGetId because it expects NodeGetID. Is the recommendation to ignore this error? Should we use something like this for the go generated file: you can use github.com/gogo/protobuf message C { optional int64 size = 1 [(gogoproto.customname) = "MySize"]; } type C struct { MySize *int64 } This is a snippet from: golang/protobuf#156 <golang/protobuf#156> Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#173 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPVLDaqlH9ps-Nxkbp8ZntghOreaumQks5tcEdLgaJpZM4RrlLO> .

[jdef]

golint should NOT be linting generated-code: https://github.com/golang/lint/blob/c72d1a524d88a66072b772f7452bd830adf57bcd/lint.go#L125

…

On Wed, Mar 7, 2018 at 3:55 PM, James DeFelice ***@***.***> wrote: Where is golint failing, exactly? When linting your client code, or the generated proto bindings? On Wed, Mar 7, 2018 at 3:47 PM, pure-yesmat ***@***.***> wrote: > Hello, > > This causes golint to fail for NodeGetId because it expects NodeGetID. Is > the recommendation to ignore this error? > > Should we use something like this for the go generated file: > > you can use github.com/gogo/protobuf > > message C { > optional int64 size = 1 [(gogoproto.customname) = "MySize"]; > } > type C struct { > MySize *int64 > } > > This is a snippet from: golang/protobuf#156 > <golang/protobuf#156> > > Thanks > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#173 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACPVLDaqlH9ps-Nxkbp8ZntghOreaumQks5tcEdLgaJpZM4RrlLO> > . >

[pure-yesmat]

The implementation of the NodeServer interface. Example:
type nodeServer struct{
}
func (ns *nodeServer) NodeGetId(...) {
}

[pure-yesmat]

Ping :)

[gpaul]

So, in your code...

[gpaul]

You're saying in order to implement the CSI spec you have to write Go code by hand that does not pass golint?

[gpaul]

I think you'll want to wait for and weigh in on golang/protobuf#555.