Skip to content

Add volume capability to volume expansion calls #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add volume capability to volume expansion calls #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,6 +1066,15 @@ message ControllerExpandVolumeRequest {
// Secrets required by the plugin for expanding the volume.
// This field is OPTIONAL.
map<string, string> secrets = 3 [(csi_secret) = true];

// Volume capability describing how the CO intends to use this volume.
// This allows SP to determine if volume is being used as a block
// device or mounted file system. For example - if volume is
// being used as a block device - the SP MAY set
// node_expansion_required to false in ControllerExpandVolumeResponse
// to skip invocation of NodeExpandVolume on the node by the CO.
// This is an OPTIONAL field.
VolumeCapability volume_capability = 4;
}

message ControllerExpandVolumeResponse {
Expand Down Expand Up @@ -1341,6 +1350,17 @@ message NodeExpandVolumeRequest {
// filesystem of the process serving this request.
// This field is OPTIONAL.
string staging_path = 4;

// Volume capability describing how the CO intends to use this volume.
// This allows SP to determine if volume is being used as a block
// device or mounted file system. For example - if volume is being
// used as a block device the SP MAY choose to skip expanding the
// filesystem in NodeExpandVolume implementation but still perform
// rest of the housekeeping needed for expanding the volume. If
// volume_capability is omitted the SP MAY determine
// access_type from given volume_path for the volume and perform
// node expansion. This is an OPTIONAL field.
VolumeCapability volume_capability = 5;
}

message NodeExpandVolumeResponse {
Expand Down
Loading