Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCapacityResponse: add maximum_volume_size #470

Merged
merged 3 commits into from
Mar 4, 2021
Merged

GetCapacityResponse: add maximum_volume_size #470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e09188b
GetCapacityResponse: add maximum_volume_size
pohly Feb 4, 2021
0600cb2
GetCapacityResponse: volume size range
pohly Feb 16, 2021
7a2fcdd
GetCapacityResponse: minimum volume size
pohly Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,24 @@ message GetCapacityResponse {
// storage. This field is REQUIRED.
// The value of this field MUST NOT be negative.
int64 available_capacity = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have added the new capacity fields for max/min volume size, can we also add comments to this existing field to explain how CO should be using this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is not clear yet. If you have a proposal, then please put it into a PR and we can discuss it.


// The largest size that may be used in a CreateVolume call
// to create a volume with the same parameters as those in
// GetCapacityRequest.
//
// If `volume_capabilities` or `parameters` is
// specified in the request, the Plugin SHALL take those into
// consideration when calculating the maximum volume size of the
// storage.
//
// This field is OPTIONAL. COs MAY use it to make decision about
// where to create volumes.
Capacity maximum_volume_size = 2 [(alpha_field) = true];
}

message Capacity {
// Number of bytes. MUST NOT be negative.
int64 value = 1;
}
message ControllerGetCapabilitiesRequest {
// Intentionally empty.
Expand Down
Loading