Skip to content

Conversation

@jieyu
Copy link
Member

@jieyu jieyu commented Aug 9, 2017

The original build is unnecessarily complex. This patch simplifies the
build process by just generating the protobuf file.

The original build is unnecessarily complex. This patch simplifies the
build process by just generating the protobuf file.
script:
- make csi.pb.go

after_success:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked having the generated artifacts, can we keep these? (requires the earlier gem install ...)

@akutz
Copy link
Contributor

akutz commented Aug 9, 2017

Hi @jieyu,

I don't see the value in this patch. The original build works fine and the external csi.mk file makes it easy for others to use that locally.

@jieyu
Copy link
Member Author

jieyu commented Aug 10, 2017

Did an offline chat with @akutz and @saad-ali. We will proceed with the following plan:

  1. Make protobuf the source of truth
  2. Reference the protobuf in the spec.md
  3. Remove libraries repo in the csi org
  4. Introduce a lib/ folder in the spec repo
  5. Putting language specific libraries (used for spec validation) in lib/ folder. First step will be a minimal client based on generated grpc code and a mock server. It'll try to validate the workflow specified in the spec doc.

cc @saad-ali

@jieyu jieyu closed this Aug 10, 2017
@jieyu jieyu deleted the build branch August 10, 2017 00:06
@akutz akutz mentioned this pull request Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants