Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osbs opentelemetry #2083

Merged
merged 2 commits into from
Sep 14, 2023
Merged

osbs opentelemetry #2083

merged 2 commits into from
Sep 14, 2023

Conversation

hjmodi
Copy link
Contributor

@hjmodi hjmodi commented Sep 6, 2023 •
edited by mkosiarc
Loading

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • [n/a] Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • [n/a] Changes to metadata also update the documentation for the metadata
  • [n/a] Pull request has a link to an osbs-docs PR for user documentation updates
  • [n/a] New feature can be disabled from a configuration file

@hjmodi hjmodi requested a review from rcerven September 6, 2023 18:23
@hjmodi hjmodi requested a review from mkosiarc September 6, 2023 20:25
hjmodi
hjmodi commented Sep 7, 2023
View reviewed changes
atomic_reactor/tasks/common.py Outdated Show resolved Hide resolved
rcerven
rcerven reviewed Sep 11, 2023
View reviewed changes
atomic_reactor/config.py Outdated Show resolved Hide resolved
@hjmodi hjmodi requested a review from rcerven September 11, 2023 18:02
mkosiarc
mkosiarc reviewed Sep 13, 2023
View reviewed changes
test.sh Outdated Show resolved Hide resolved
mkosiarc
mkosiarc reviewed Sep 13, 2023
View reviewed changes
requirements-devel.in Outdated Show resolved Hide resolved
@mkosiarc
Copy link
Contributor

@hjmodi Without context, the commit messages do not seem sufficiently descriptive to me. Would it be possible to have a longer description and/or mention the JIRA id of the work, so we can find it easily in the future if necessary?

@hjmodi
Copy link
Contributor Author

hjmodi commented Sep 13, 2023

@hjmodi Without context, the commit messages do not seem sufficiently descriptive to me. Would it be possible to have a longer description and/or mention the JIRA id of the work, so we can find it easily in the future if necessary?

I have updated the commit messages to add a bit more info plus story id.

@mkosiarc mkosiarc self-requested a review September 13, 2023 15:41
@hjmodi
opentelemetry: instrument OSBS base task
49abb30 
We are initilizing opentelemetry libraries at
the start of every task.

This will allow us to get traces of all HTTP requests
made in different tasks.

* MMENG-3834

Signed-off-by: Harsh Modi <hmodi@redhat.com>
@hjmodi
instrument binary_container_build task
9bc4549 
to get specific execution information.

This information can help us query the traces database,
based on specific attributes set in given spans.

* MMENG-3834

Signed-off-by: Harsh Modi <hmodi@redhat.com>
@hjmodi hjmodi merged commit ed80d31 into containerbuildsystem:master Sep 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcerven rcerven rcerven approved these changes

@mkosiarc mkosiarc mkosiarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjmodi @mkosiarc @rcerven