Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imp module): replace deprecated module #2123

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartinBasti
Copy link
Contributor

imp module has been replaced by importlib in python 3.12 and is not available anymore

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

imp module has been replaced by importlib in python 3.12 and is not
available anymore

Signed-off-by: Martin Basti <mbasti@redhat.com>
@MartinBasti
Copy link
Contributor Author

This should be 1-1 replacement, but for some reason tests are 7 times slower, something is off here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant