Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundler package manager: fixes / improvements #717

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bundler package manager: fixes / improvements #717

wants to merge 3 commits into from

Conversation

slimreaper35
Copy link
Collaborator

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

@slimreaper35 slimreaper35 requested review from a-ovchinnikov and eskultety and removed request for a-ovchinnikov November 1, 2024 13:55
@slimreaper35
generic pkg manager: Regenerate test data
91f6064 
Signed-off-by: Michal Šoltis <msoltis@redhat.com>
@slimreaper35
bundler: Access all gems using direct download URL instead of hosted …
fbc8320 
…package index

Use `urljoin` from `urlib.parse` to join the source
repository and the name of the gem.

Signed-off-by: Michal Šoltis <msoltis@redhat.com>
@slimreaper35
bundler(fix): Add cachi2:found_by property to SBOM components
b89fdbc 
cachi2:found_by property is added to a component by default
**when creating an object**

This commit fixes a bug, when components that had extra property
cachi2:bundler:package:binary did not have cachi2:found_by property
as all other components.

Test data are updated accordingly.

Signed-off-by: Michal Šoltis <msoltis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskultety eskultety eskultety approved these changes

@a-ovchinnikov a-ovchinnikov a-ovchinnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimreaper35 @a-ovchinnikov @eskultety