bundler git deps fixes #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimreaper35
force-pushed
the
bundler
branch
from
c2577f7 to
2f40be4
Compare
If the branch does exist, checkout the branch in the repository. Do not go to detached state afterwards. Use `git reset --hard` instead. Signed-off-by: Michal Šoltis <msoltis@redhat.com>
The name of the cached git repository comes from git URL, not from the name declared in the Gemfile. We use `repo_name` property for that in the `GitDependency` class [1]. Reuse the property for the cache path in the bundler config file as well. --- [1]: https://github.com/containerbuildsystem/cachi2/blob/main/cachi2/core/package_managers/bundler/parser.py#L143 Signed-off-by: Michal Šoltis <msoltis@redhat.com>
slimreaper35
force-pushed
the
bundler
branch
from
2f40be4 to
52c7c97
Compare
a-ovchinnikov
approved these changes
Dec 19, 2024
brunoapimentel
approved these changes
Dec 19, 2024
Merged
via the queue into
containerbuildsystem:main
with commit Dec 19, 2024
7fb76a9
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)