Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI issues #1136

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

mkosiarc
Copy link
Contributor

@mkosiarc mkosiarc commented Aug 6, 2024

See the individual commit messages for details

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates

Newer versions of pytest cause issues for flexmock, causing failures in
tests CI such as:

tests/utils/test_yaml.py:11: in <module>
    from flexmock import flexmock
/usr/lib/python3.10/site-packages/flexmock/__init__.py:2: in <module>
    from flexmock import _integrations  # pylint: disable=unused-import
/usr/lib/python3.10/site-packages/flexmock/_integrations.py:101: in <module>
    saved_pytest = runner.call_runtest_hook
E   AttributeError: module '_pytest.runner' has no attribute 'call_runtest_hook'

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
this version contains git and fixes the error:
[  ERROR ] Git not available, reinstall with baseline extra

This is the same fix as in atomic-reactor repo containerbuildsystem/atomic-reactor@1f46fbe

Also the quotes are neccessary to fix the shellcheck error:
In ./test.sh line 86:
  $RUN $PIP install bandit[baseline]
                          ^--------^ SC2102: Ranges can only match single chars (mentioned due to duplicates).

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
same fix as in atomic-reactor repo
containerbuildsystem/atomic-reactor@89e4b82

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
@mkosiarc mkosiarc changed the title Freeze pytest version Fix the CI issues Aug 6, 2024
@mkosiarc mkosiarc merged commit 50abfc7 into containerbuildsystem:master Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants