Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the CI issues #1136

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix the CI issues #1136

merged 3 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. Freeze pytest version 

    Newer versions of pytest cause issues for flexmock, causing failures in
tests CI such as:

tests/utils/test_yaml.py:11: in <module>
    from flexmock import flexmock
/usr/lib/python3.10/site-packages/flexmock/__init__.py:2: in <module>
    from flexmock import _integrations  # pylint: disable=unused-import
/usr/lib/python3.10/site-packages/flexmock/_integrations.py:101: in <module>
    saved_pytest = runner.call_runtest_hook
E   AttributeError: module '_pytest.runner' has no attribute 'call_runtest_hook'

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
    @mkosiarc
    mkosiarc committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7fa9813 View commit details
    Browse the repository at this point in the history

  2. Install baseline bandit 

    this version contains git and fixes the error:
[  ERROR ] Git not available, reinstall with baseline extra

This is the same fix as in atomic-reactor repo containerbuildsystem/atomic-reactor@1f46fbe

Also the quotes are neccessary to fix the shellcheck error:
In ./test.sh line 86:
  $RUN $PIP install bandit[baseline]
                          ^--------^ SC2102: Ranges can only match single chars (mentioned due to duplicates).

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
    @mkosiarc
    mkosiarc committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    adddfcd View commit details
    Browse the repository at this point in the history

  3. Replace markdownlint action 

    same fix as in atomic-reactor repo
containerbuildsystem/atomic-reactor@89e4b82

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
    @mkosiarc
    mkosiarc committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bffe02b View commit details
    Browse the repository at this point in the history