Skip to content

Conversation

@AkihiroSuda
Copy link
Member

Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment)
Related: #1598

Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 16, 2019

Build succeeded.

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #3419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         113      113           
  Lines       12563    12563           
=======================================
  Hits         5660     5660           
  Misses       6049     6049           
  Partials      854      854
Flag Coverage Δ
#linux 48.98% <ø> (ø) ⬆️
#windows 40.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e4c8e...fab016c. Read the comment docs.

@tao12345666333
Copy link
Contributor

A small note, it's on Fedora release 29 (Twenty Nine). 😄

@AkihiroSuda
Copy link
Member Author

Reproducible on 30 as well

@tao12345666333
Copy link
Contributor

Thank you. 👍

Fix a Rootless Docker-in-Docker issue on Fedora 30: docker-library/docker#165 (comment)
Related: containerd#1598

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2019

Build succeeded.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants