Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly ignore error wrapping ErrNotSupported #207

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Correctly ignore error wrapping ErrNotSupported #207

merged 1 commit into from
Aug 10, 2022

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Aug 10, 2022

Fixes: #206

This change fixes some existing tests which were failing on WIndows:

--- FAIL: TestCopyDirectory (0.03s)
    copy_test.go:45: Copy test failed: failed to build manifest: failed to get resource "\\etc": xattr extraction is not supported: not supported
--- FAIL: TestCopyDirectoryWithLocalSymlink (0.01s)
    copy_test.go:59: Copy test failed: failed to build manifest: failed to get resource "\\link-no-nothing.txt": xattr extraction for symlinks is not supported: not supported
--- FAIL: TestCopyWithLargeFile (9.17s)
    copy_test.go:74: failed to build manifest: failed to get resource "\\banana": xattr extraction is not supported: not supported

The same issue was visible with the command-line tool

> .\continuity.exe build . > ../a.pb
2022/08/11 02:15:44 error generating manifest: failed to get resource "\\.git": xattr extraction is not supported: not supported

now looks like

> .\continuity.exe build . > ../a.pb

@TBBle TBBle mentioned this pull request Aug 10, 2022
Closed
10 tasks
@TBBle
Correctly ignore error wrapping ErrNotSupported
1ee38b5 
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
estesp
estesp approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit b4ca352 into containerd:main Aug 10, 2022
@TBBle TBBle deleted the correctly-ignore-xattrs-on-windows branch August 10, 2022 23:40
TBBle added a commit to TBBle/containerd that referenced this pull request Aug 10, 2022
@TBBle
🚨HACK: Upgrade to continuity main branch
d18282a 
This is to pull in the fix for ignoring lack of xattrs support.

containerd/continuity#207
TBBle added a commit to TBBle/containerd that referenced this pull request Aug 10, 2022
@TBBle
🚨HACK: Upgrade to continuity main branch
cee0921 
This is to pull in the fix for ignoring lack of xattrs support.

containerd/continuity#207
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/containerd that referenced this pull request Aug 10, 2022
@TBBle
🚨HACK: Upgrade to continuity main branch
3e890e8 
This is to pull in the fix for ignoring lack of xattrs support.

containerd/continuity#207
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/containerd that referenced this pull request Aug 11, 2022
@TBBle
🚨HACK: Upgrade to continuity main branch
046bf36 
This is to pull in the fix for ignoring lack of xattrs support.

containerd/continuity#207
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle added a commit to TBBle/containerd that referenced this pull request Aug 11, 2022
@TBBle
🚨 HACK: Upgrade to continuity main branch
f8ec723 
This is to pull in the fix for ignoring lack of xattrs support.

containerd/continuity#207
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continuity is failing to ignore unsupported xattrs on Windows
3 participants
@TBBle @samuelkarp @estesp