Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Avoid O_NONBLOCK on stdout in the windows test. #1324

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Oct 23, 2019

This is a trial to fix the windows test.

See kubernetes/test-infra#14938 for more details.
/cc @BenTheElder

Signed-off-by: Lantao Liu lantaol@google.com

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu
Copy link
Member Author

From the log, we can see that O_NONBLOCK is set by mistake:

+ python -c 'import os,sys,fcntl; flags = fcntl.fcntl(sys.stdout, fcntl.F_GETFL); print(flags&os.O_NONBLOCK);'
2048
+ python -c 'import os,sys,fcntl; flags = fcntl.fcntl(sys.stdout, fcntl.F_GETFL); fcntl.fcntl(sys.stdout, fcntl.F_SETFL, flags&~os.O_NONBLOCK);'

So this fix makes sense.

@yujuhong
Copy link
Member

/lgtm

@Random-Liu Random-Liu merged commit a7c5a65 into containerd:master Oct 25, 2019
@Random-Liu Random-Liu deleted the stdout-non-block branch October 25, 2019 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants