This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
[WIP] Replacing nsenter with netns #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has changes to replace the usage of nsenter with netns. This can relax the requirement of requiring nsenter installation. Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
|
Will update doc if we want to take this path |
|
Need to figure out how to solve vishvananda/netns#17 and golang/go#20676. This seems to be a WIP then. :) |
|
The golang issue will be solved in golang 1.10 (hopefully). At that time, we could use We could get rid of all the nsenters at that time. |
|
Woot Woot ! Thanks for the update @Random-Liu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has changes to replace the usage of nsenter with
netns. This can relax the requirement of requiring nsenter
installation.
Signed-off-by: Abhinandan Prativadi abhi@docker.com