Remove references to io/ioutil package #45
Conversation
austinvazquez
force-pushed
the
remove-ioutil
branch
from
30779b5 to
47af5e9
Compare
austinvazquez
force-pushed
the
remove-ioutil
branch
from
47af5e9 to
b198e8b
Compare
austinvazquez
force-pushed
the
remove-ioutil
branch
4 times, most recently
from
85dd95c to
12b5c42
Compare
fuseoverlayfs.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get snapshot %s from storage: %w", key, err) | ||
| } |
There was a problem hiding this comment.
Resolves ineffectual assignment of err. If storage.GetSnapshot call fails then s == snapshots.Snapshot{} or empty snapshot struct. From my read it made sense to propagate the error here instead of continuing and attempting to mount an empty snapshot. Lmk your thoughts.
fuseoverlayfs.go
Outdated
| @@ -182,9 +181,12 @@ func (o *snapshotter) Mounts(ctx context.Context, key string) ([]mount.Mount, er | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| defer t.Rollback() | |||
There was a problem hiding this comment.
Moved just for readability / matches the standard practice of other functions in this snapshotter.
|
@AkihiroSuda, I removed some not required changes if you would take a second look. Enabling errcheck could probably be its own PR as most of its warnings are around checking of rollback errors on non-writable transactions which is unlikely to fail. |
.github/workflows/release.yml
Outdated
| env: | ||
| GO111MODULE: on | ||
| GO_VERSION: 1.20.x |
.github/workflows/main.yml
Outdated
| @@ -5,6 +5,10 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
|
|
|||
| env: | |||
| GO_VERSION: 1.20.x | |||
|
Sorry, overlooked this, needs rebase |
|
@austinvazquez could you address the review comments? |
Package io/ioutil has been marked deprecated in Go 1.16. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
remove-ioutil
branch
from
12b5c42 to
7bbea67
Compare
|
@thaJeztah, updated. Thanks for the ping. |
|
Thanks! I stumbled on this one when I opened a PR here 😂 |
Package io/ioutil has been marked deprecated in Go 1.16.
Signed-off-by: Austin Vazquez macedonv@amazon.com