Add Go 1.20 support #111
Merged
Add Go 1.20 support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
commented
Feb 9, 2023
.github/workflows/ci.yml
Outdated
| @@ -44,7 +44,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| go-version: [1.17.x] | |||
| go-version: [1.17.x, 1.18.x, 1.19.x, 1.20.x] | |||
There was a problem hiding this comment.
Linting with each version of Go might be a little pedantic. Lmk your thoughts.
There was a problem hiding this comment.
No need to support 1.17 and 1.18
There was a problem hiding this comment.
yeah, let's just keep it to the last 2 supported releases of Go
There was a problem hiding this comment.
Sounds good. Pushed an update with the changes.
austinvazquez
force-pushed
the
add-go-1.20-support
branch
2 times, most recently
from
b2ef584 to
0083665
Compare
Updates containerd/project-checks to v1.1.0 to run with Go 1.20. Updates golangci/golangci-lint to v1.51.1 for Go 1.20 support. Adds Go 1.20 to lint and test steps. Bumps minimum required version to Go 1.19 Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
add-go-1.20-support
branch
from
0083665 to
4930cbf
Compare
AkihiroSuda
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates containerd/project-checks to v1.1.0 to run with Go 1.20. Updates
golangci/golangci-lint to v1.51.1 for Go 1.20 support. Adds Go 1.20 to
lint and test steps. Bumps minimum required version to Go 1.19
Signed-off-by: Austin Vazquez macedonv@amazon.com