Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CNI to v1.0.0 #70

Merged
merged 2 commits into from
Aug 20, 2021
Merged

update CNI to v1.0.0 #70

merged 2 commits into from
Aug 20, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Aug 12, 2021

https://github.com/containernetworking/cni/blob/v1.0.0/Documentation/spec-upgrades.md

CNI v1.0 has the following changes:

  • non-List configurations are removed
  • the version field in the interfaces array was redundant and is removed

libcni Changes in CNI v1.0

/pkg/types/current no longer exists

This means that runtimes need to explicitly select a version they support.
This reduces code breakage when revendoring cni into other projects and
returns the decision on which CNI Spec versions a plugin supports to the
plugin's authors.

For example, your Go imports might look like

import (
   cniv1 "github.com/containernetworking/cni/pkg/types/100"
)

Full changes: containernetworking/cni@v0.8.0...v1.0.0

@codecov-commenter
Copy link

Codecov Report

Merging #70 (786c2bc) into main (a139c32) will increase coverage by 2.30%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   39.93%   42.23%   +2.30%     
==========================================
  Files           9        9              
  Lines         293      367      +74     
==========================================
+ Hits          117      155      +38     
- Misses        147      181      +34     
- Partials       29       31       +2     
Impacted Files Coverage Δ
deprecated.go 0.00% <0.00%> (ø)
result.go 79.31% <66.66%> (+0.14%) ⬆️
cni.go 70.96% <100.00%> (+5.21%) ⬆️
helper.go 60.00% <100.00%> (+17.14%) ⬆️
namespace.go 73.07% <100.00%> (+0.85%) ⬆️
errors.go 0.00% <0.00%> (ø)
namespace_opts.go 0.00% <0.00%> (ø)
opts.go 15.90% <0.00%> (+0.59%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a139c32...786c2bc. Read the comment docs.

@AkihiroSuda AkihiroSuda requested a review from abhi August 16, 2021 09:22
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 548a5e1 into containerd:main Aug 20, 2021
@AkihiroSuda
Copy link
Member Author

@dmcgowan @estesp May I tag v1.1.0 in this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants