Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common project content/checks #51

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Feb 26, 2019

In order to make sure that there is no flaky case, clear the
XDG_RUNTIME_DIR env before test the TestTempConsole.

Signed-off-by: Wei Fu fuweid89@gmail.com

@fuweid fuweid changed the title Add common project content/checks [WIP] Add common project content/checks Feb 26, 2019
@fuweid fuweid force-pushed the add-content-check branch 2 times, most recently from e65f5aa to cf705aa Compare February 26, 2019 06:34
In order to make sure that there is no flaky case, clear the
`XDG_RUNTIME_DIR` env before test the `TestTempConsole`.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5a6d9f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #51   +/-   ##
========================================
  Coverage          ?   6.18%           
========================================
  Files             ?       7           
  Lines             ?     631           
  Branches          ?       0           
========================================
  Hits              ?      39           
  Misses            ?     585           
  Partials          ?       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6d9f3...8e51df4. Read the comment docs.

@fuweid fuweid changed the title [WIP] Add common project content/checks Add common project content/checks Feb 26, 2019
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 7d11b49 into containerd:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants