Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Vagrantfile.freebsd: pin generic/freebsd13 to version 4.3.2; compose_config_test: workaround for Docker Compose v2.23.0 #2606

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

AkihiroSuda
Copy link
Member

Vagrantfile.freebsd: pin generic/freebsd13 to version 4.3.2

The latest version (v4.3.4) is currently broken

Fix #2596

Carry #2597 (originally submitted by @yankay)

compose_config_test: workaround for Docker Compose v2.23.0

The test for docker compose config --hash=* has to be temporarily skipped,
as docker compose config --hash=* is broken in Docker Compose v2.23.0

Fix #2605

AkihiroSuda and others added 2 commits October 28, 2023 00:34
The latest version (v4.3.4) is currently broken

Fix issue 2596

Carry PR 2597 (originally submitted by yankay)

Co-authored-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
The test for `docker compose config --hash=*` has to be temporarily skipped,
as `docker compose config --hash=*` is broken in Docker Compose v2.23.0
(docker/compose issue 11145)

Fix issue 2605

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Oct 27, 2023
@AkihiroSuda AkihiroSuda added this to the v1.6.3 milestone Oct 27, 2023
@AkihiroSuda AkihiroSuda requested a review from yankay October 27, 2023 15:34
@AkihiroSuda AkihiroSuda changed the title Fix ci Fix CI: Vagrantfile.freebsd: pin generic/freebsd13 to version 4.3.2; compose_config_test: workaround for Docker Compose v2.23.0 Oct 27, 2023
@AkihiroSuda AkihiroSuda requested a review from yuchanns October 27, 2023 15:36
Copy link
Contributor

@yuchanns yuchanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 2becba6 into containerd:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
2 participants