feat(compose_up): add --abort-on-container-exit flag #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alegrey91
force-pushed
the
feat/add-abort-on-container-exit-flag-compose-up
branch
from
6bfd736 to
c1bfc73
Compare
alegrey91
force-pushed
the
feat/add-abort-on-container-exit-flag-compose-up
branch
2 times, most recently
from
54f8a96 to
f5d6c66
Compare
|
@AkihiroSuda could you please re-run the pipeline? |
|
done. Next time your can rewrite your commit this will trigger the pipeline |
Thanks! |
AkihiroSuda
reviewed
Mar 13, 2024
pkg/composer/logs.go
Outdated
| @@ -39,7 +40,7 @@ type LogsOptions struct { | |||
| NoLogPrefix bool | |||
| } | |||
|
|
|||
| func (c *Composer) Logs(ctx context.Context, lo LogsOptions, services []string) error { | |||
| func (c *Composer) Logs(ctx context.Context, lo LogsOptions, services []string, abortOnContainerExit bool) error { | |||
There was a problem hiding this comment.
Why not add this to LogsOption?
There was a problem hiding this comment.
I thought it was out of scope, but if it's ok for you I can move it under the LogsOption struct
AkihiroSuda
reviewed
Mar 13, 2024
docs/command-reference.md
Outdated
There was a problem hiding this comment.
Please consider squashing commits
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
alegrey91
force-pushed
the
feat/add-abort-on-container-exit-flag-compose-up
branch
from
f5d6c66 to
0f9c8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795 .
This PR adds the flag
--abort-on-container-exitflag fornerdctl compose upcommand.As the flag says, using it all containers are being stopped if any container was stopped during the run.