Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DHCP CNI plugin IPAM options and set the DHCP host-name option properly #3001

Merged
merged 1 commit into from
May 20, 2024
Merged

Add support for DHCP CNI plugin IPAM options and set the DHCP host-name option properly #3001

merged 1 commit into from
May 20, 2024

Conversation

apostasie
Copy link
Contributor

AkihiroSuda
AkihiroSuda reviewed May 14, 2024
View reviewed changes
docs/cni.md Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda requested a review from junnplus May 14, 2024 08:56
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone May 14, 2024
@apostasie apostasie requested a review from AkihiroSuda May 14, 2024 18:43
@apostasie
Support DHCP IPAM opts and set the hostname
480eb6e 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Contributor Author

Rebased.
The cni plugins sha failure is now gone.

PTAL.

Still some (random?) CI failure - unless I am responsible for these, it seems to me these are just flaky. It is really annoying.
I want these problems gone. Will have a look at them once done with image inspect.

@AkihiroSuda AkihiroSuda requested review from a team May 17, 2024 03:47
AkihiroSuda
AkihiroSuda approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 6b56f82 into containerd:main May 20, 2024
22 checks passed
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@junnplus junnplus Awaiting requested review from junnplus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Supply container hostname in CNI_ARGS
2 participants
@apostasie @AkihiroSuda