Remove Docker incompat from image prune and build tests #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
AkihiroSuda
reviewed
Aug 19, 2024
| base := testutil.NewBase(t) | ||
| base.Env = append(base.Env, fmt.Sprintf("SOURCE_DATE_EPOCH=%d", time.Now().Add(-2*time.Hour).Unix())) |
There was a problem hiding this comment.
Needs a comment line to explain this
austinvazquez
force-pushed
the
remove-docker-incompat-from-tests
branch
3 times, most recently
from
cc9b0f3 to
e5aab95
Compare
|
I was hoping we could remove the sleep and deterministically test with the SOURCE_DATE_EPOCH; however, through testing it appears images built with containerd v1.6 are not respecting the SOURCE_DATE_EPOCH. |
|
Looks like 1.6 will be supported until at least Feb 2025... https://containerd.io/releases/ I am not sure it is worth the effort, but we could specialize this test for different versions of containerd? ( |
apostasie
reviewed
Aug 22, 2024
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
remove-docker-incompat-from-tests
branch
from
e5aab95 to
6362afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is a followup to #3319 to enable image prune filter until integration tests on Docker.
SOURCE_DATE_EPOCHis available in buildx since v0.10 which should be available in Docker 23 and greater.Testing
TestImagePruneFilterUntilon DockerTestBuildSourceDateEpochon Docker