Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Windows CI failure with containerd 1.5.8 #534

Closed
wants to merge 1 commit into from
Closed

Debug Windows CI failure with containerd 1.5.8 #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,24 @@ docker_builder:
os_version: 2019
env:
CGO_ENABLED: 0
# yamllint disable rule:key-duplicates
matrix:
ContainerdVersion: 1.5.7
ContainerdVersion: 1.5.8
ContainerdVersion: 1.6.0-beta.3
build_script:
- mkdir "C:\Windows\system32\config\systemprofile\AppData\Local\Temp\"
- powershell hack/configure-windows-ci.ps1
- refreshenv
- go install .\cmd\nerdctl\
- go test -v -run "^(TestRunWorkdir|TestRunWithDoubleDash|TestRunExitCode|TestRunCIDFile|TestRunEnvFile|TestRunEnv|TestExec|ImageInspect|TestRunUserName)$" ./cmd/...

- nerdctl run --rm gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 echo hello
- nerdctl run --rm gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -euxc "echo hello2"

- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sleep 1h
- nerdctl exec nerdctl-test-exec echo hello3
- nerdctl rm -f nerdctl-test-exec

- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -euxc "sleep 1h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -euxc "sleep 1h"
- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -eux "sleep 1h"

still working on why but this should let it pass

- nerdctl exec nerdctl-test-exec sh -euxc "echo hello4"
- nerdctl rm -f nerdctl-test-exec
3 changes: 1 addition & 2 deletions hack/configure-windows-ci.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ $ErrorActionPreference = "Stop"
choco install --limitoutput --no-progress -y golang

#install containerd
$Version="1.5.7"
curl.exe -L https://github.com/containerd/containerd/releases/download/v$Version/containerd-$Version-windows-amd64.tar.gz -o containerd-windows-amd64.tar.gz
curl.exe -L https://github.com/containerd/containerd/releases/download/v$Env:ContainerdVersion/containerd-$Env:ContainerdVersion-windows-amd64.tar.gz -o containerd-windows-amd64.tar.gz
tar xvf containerd-windows-amd64.tar.gz
mkdir -force "$Env:ProgramFiles\containerd"
mv ./bin/* "$Env:ProgramFiles\containerd"
Expand Down