Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: promote Fahed Dorgaa from a REVIEWER to a COMMITTER #563

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 24, 2021

@fahedouch has made significant contributions (https://github.com/containerd/nerdctl/issues?q=author%3Afahedouch), so I'd like to promote @fahedouch from a Reviewer to be a Committer.

Needs explicit LGTM from:

I'd also like to get a few LGTMs from the Core Committers too.

@AkihiroSuda AkihiroSuda requested review from a team November 24, 2021 04:45
@fahedouch
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Rebased

@AkihiroSuda AkihiroSuda added this to the v0.15.0 milestone Nov 30, 2021
@AkihiroSuda
Copy link
Member Author

@dmcgowan Could you sync https://github.com/orgs/containerd/teams/nerdctl-maintainers with the MAINTAINERS file

@AkihiroSuda AkihiroSuda merged commit 3515de1 into containerd:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants