Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iidfile flag for build image #589

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

junnplus
Copy link
Member

@junnplus junnplus commented Dec 2, 2021

related #215

cmd/nerdctl/build.go Outdated Show resolved Hide resolved
cmd/nerdctl/build.go Outdated Show resolved Hide resolved
cmd/nerdctl/build.go Outdated Show resolved Hide resolved
@junnplus junnplus force-pushed the iidfile branch 2 times, most recently from 4fac94c to c6198fe Compare December 3, 2021 03:47
cmd/nerdctl/build.go Outdated Show resolved Hide resolved
cmd/nerdctl/build.go Outdated Show resolved Hide resolved
@junnplus junnplus force-pushed the iidfile branch 3 times, most recently from cce4f44 to 762e1fe Compare December 3, 2021 06:11
@AkihiroSuda AkihiroSuda requested a review from ktock December 3, 2021 06:27
@AkihiroSuda AkihiroSuda added this to the v0.15.0 milestone Dec 3, 2021
@ktock
Copy link
Member

ktock commented Dec 3, 2021

Got a different result than docker after some manual testing.

docker:

$ docker build -t test --iidfile=/tmp/iid /tmp/ctx
$ cat /tmp/iid
sha256:c74973c38ea79154adb9c8caf29e4be8f9b09690f08cd36bee480b3568ba2da5
$ docker image inspect test | jq -r '.[0].Id'
sha256:c74973c38ea79154adb9c8caf29e4be8f9b09690f08cd36bee480b3568ba2da5

nerdctl:

# nerdctl build -t test --iidfile=/tmp/iid /tmp/ctx
# cat /tmp/iid
sha256:84199e0a1de5a053170744bd4b7d6333480ada680136a9fed0e811e409fc1946
# nerdctl image inspect test | jq -r '.[0].Id'
sha256:c7a9088f63ec485c116a91e5f6834c2dba5e55da5a390b87a8864bcde9778432

iidfile should be that same as nerdctl image inspect at least.

@AkihiroSuda
Copy link
Member

iidfile should be that same as nerdctl image inspect at least.

No.
#442

@ktock
Copy link
Member

ktock commented Dec 3, 2021

LGTM on green

Signed-off-by: ye.sijun <junnplus@gmail.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member

Added a follow-up commit for docs

@AkihiroSuda AkihiroSuda merged commit a6992ab into containerd:master Dec 6, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 13, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants